[core] Remove update-monorepo.yml #3712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Janpot
approved these changes
Jun 26, 2024
|
I started working on this but we ended with renovatebot updating this dependency. |
|
Ah makes sense. What did you envision that could be improved over Renovate? |
At the moment, nothing. At the time I believe we had to manually update the monorepo dependency and I started building an action to automate it. Then after pnpm migration and pinning the monorepo dependency, I found renovate could handle updates properly. I just forgot about the half built github action still being in the repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We seem to never use this workflow: https://github.com/mui/mui-toolpad/actions/workflows/update-monorepo.yml. It was created in #2243. I guess we don't need this? It's flagged as having a potential security issue https://github.com/mui/mui-toolpad/security/code-scanning/70.