Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Add PageContainer component #3713

Merged
merged 56 commits into from
Jul 24, 2024
Merged

[core] Add PageContainer component #3713

merged 56 commits into from
Jul 24, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jun 27, 2024

Closes #3746

Adds a page container component tat extends the MUI core container with title, breadcrumbs and actions. Added it as well to the layout if the default generated page in the CLI.

@apedroferreira Proposing a change to slug here. As it represents the url segments i.e. the things that go between slashes it could make sense to not include the slash in them. I'm also removing the Container from the DashboardLayout. We can leave this to the user, or in this case the PageContent component. 🤔 Maybe we need to rename it to segment as "slug" may mean something else in the context of urls?

resolved in #3794

docs preview
tutorial preview

SCR-20240810-rstr

To do

  • docs theming issues
  • actions area doesn't overflow on small screen
  • add in overview features section
  • add in CLI to be generated in specific pages layout.tsx
  • update tutorial to contain this component

@Janpot Janpot added the core Infrastructure work going on behind the scenes label Jun 27, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 5, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 5, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 6, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 16, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 16, 2024
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Jul 17, 2024
@Janpot Janpot changed the title [WIP] PageContent component [WIP] PageContainer component Jul 22, 2024
@Janpot Janpot marked this pull request as ready for review July 24, 2024 10:08
@Janpot Janpot requested a review from a team July 24, 2024 10:08
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 24, 2024
Copy link
Member

@bharatkashyap bharatkashyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Added some readability comments that can be addressed in a follow up. Approving.

Janpot and others added 6 commits July 24, 2024 16:28
…r.md

Co-authored-by: Bharat Kashyap <bharatkashyap@outlook.com>
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
…r.md

Co-authored-by: Bharat Kashyap <bharatkashyap@outlook.com>
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
…r.md

Co-authored-by: Bharat Kashyap <bharatkashyap@outlook.com>
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
…r.md

Co-authored-by: Bharat Kashyap <bharatkashyap@outlook.com>
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
…r.md

Co-authored-by: Bharat Kashyap <bharatkashyap@outlook.com>
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
…r.md

Co-authored-by: Bharat Kashyap <bharatkashyap@outlook.com>
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
@Janpot Janpot changed the title [WIP] PageContainer component [core] PageContainer component Jul 24, 2024
@Janpot Janpot changed the title [core] PageContainer component [core] Add PageContainer component Jul 24, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 24, 2024
@Janpot Janpot enabled auto-merge (squash) July 24, 2024 15:15
@Janpot Janpot merged commit c4c1e3c into mui:master Jul 24, 2024
13 checks passed
@Janpot Janpot deleted the page-content branch July 24, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: layout core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PageContent component
3 participants