Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Add information when --example is present #3749

Merged
merged 5 commits into from
Jul 5, 2024

Conversation

bharatkashyap
Copy link
Member

@bharatkashyap bharatkashyap commented Jul 2, 2024

  • Remove long silence and add verbosity when create-toolpad-app is run with the --example flag:
Before After
Screenshot 2024-07-02 at 2 23 18 PM Screenshot 2024-07-02 at 2 02 26 PM

@bharatkashyap bharatkashyap changed the title [cli] Remove silence when --example is present [cli] Add information when --example is present Jul 2, 2024
@bharatkashyap bharatkashyap added the create-toolpad-app Issues related to the `create-toolpad-app` CLI tool label Jul 2, 2024
@bharatkashyap bharatkashyap requested a review from Janpot July 3, 2024 19:35
await pipeline(Readable.fromWeb(response.body), createWriteStream(tempFile));
const readable = Readable.fromWeb(response.body);
readable.on('data', (chunk) => {
process.stdout.write(`Downloading… ${(current / 1000000).toFixed(2)} MBs\r`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could potentially use

new Intl.NumberFormat('en-US', { style:'unit', unit: 'megabyte' })

for nicer number formatting

@bharatkashyap bharatkashyap merged commit bcef39e into mui:master Jul 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-toolpad-app Issues related to the `create-toolpad-app` CLI tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants