[core] Add more OAuth providers to SignInPage
#3933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bharatkashyap
commented
Aug 14, 2024
•
bharatkashyap
commented
- Closes Add more OAuth Providers and update docs, CLI #3930
- Merge after [cli] Clean templates, fix a bunch of issues in generated apps #4040
bharatkashyap
changed the title
SignInPage
apedroferreira
approved these changes
Aug 19, 2024
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
Janpot
reviewed
Aug 28, 2024
| - Discord | ||
| - Keycloak | ||
| - Credentials (username/password) | ||
| Find the list of supported providers in the [API reference](/toolpad/core/api/sign-in-page/#sign-in-page-prop-providers). |
There was a problem hiding this comment.
This feels worse. Can't we do the opposite? Keep the list here and just call it a string in the API docs?
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
added
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
github-actions
bot
added
the
PR: out-of-date
bharatkashyap
force-pushed
the
oauth-more-providers
branch
from
aa528b2
to
5bf58e1
Compare
github-actions
bot
removed
the
PR: out-of-date
|
Merging with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.