[core] Polish SignInPage and docs
#3935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bharatkashyap
commented
Aug 16, 2024
bharatkashyap
commented
- Closes Polish SignInPage and docs #3931
bharatkashyap
added
docs
…pad into enh/signin-polish
|
Ideally the palette mode of these demos follows the one from the docs. Now it shows the light theme in the demo and the dark theme of the docs here: Compared with the |
Janpot
reviewed
Aug 19, 2024
| submitButton: PropTypes.object, | ||
| }), | ||
| /** | ||
| * Custom components to override internal components |
There was a problem hiding this comment.
Suggestion: use the same text as Core
Janpot
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.