[docs] Link docs from component demos on Toolpad Core landing page #4013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we could go with this kind of an overlay on the code for the links; much more unmissable and attractive: |
|
I don't think it will bring much difference. |
Janpot
reviewed
Aug 29, 2024
Janpot
reviewed
Aug 29, 2024
There was a problem hiding this comment.
I think we could go with this kind of an overlay on the code for the links: much more unmissable and attractive:
Personally I find a link more intuitive than a button as a way to get to a page in our documentation. This follows the X landing page, it feels better to me than to core landing page.
Co-authored-by: Jan Potoms <2109932+Janpot@users.noreply.github.com> Signed-off-by: Prakhar Gupta <92228082+prakhargupta1@users.noreply.github.com>
Janpot
reviewed
Sep 5, 2024
Janpot
reviewed
Sep 5, 2024
Co-authored-by: Jan Potoms <2109932+Janpot@users.noreply.github.com> Signed-off-by: Prakhar Gupta <92228082+prakhargupta1@users.noreply.github.com>
Janpot
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://deploy-preview-4013--mui-toolpad-docs.netlify.app/toolpad/