Fixes for docs and DashboardLayout component #4104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apedroferreira
force-pushed
the
dashboard-layout-fixes
branch
from
1bc577b
to
84e6a5b
Compare
Janpot
reviewed
Sep 18, 2024
| @@ -230,7 +230,7 @@ describe('DashboardLayout', () => { | |||
|
|
|||
| const { rerender } = render(<AppWithPathname pathname="/dashboard" />); | |||
|
|
|||
| const navigation = screen.getByRole('navigation'); | |||
| const navigation = screen.getAllByRole('navigation').at(-1)!; | |||
There was a problem hiding this comment.
Might want to label these instead, as per https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/navigation_role#multiple_landmarks
There was a problem hiding this comment.
Ah cool, there should never actually be multiple navs in the page except in these headless browser tests, but anyway doesn't hurt to add these.
There was a problem hiding this comment.
The way I look at it is that if it's hard to navigate the accessibility tree in the tests, it could be an indicator that it's going to be hard for assistive software as well.
1 task
Janpot
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DashboardLayoutdocs (Closes Search bar looks strange when filled on dark mode #4037)DashboardLayoutdocsdisableCollapsibleSidebarpropuseMediaQueryhookDashboardLayoutnavigation item actions demo (there were extra slashes)https://deploy-preview-4104--mui-toolpad-docs.netlify.app/toolpad/core/react-dashboard-layout/
Before: https://mui.com/toolpad/core/react-dashboard-layout/