Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update/correct toolpad repository links in package.json #4113

Merged
merged 3 commits into from
Sep 18, 2024
Merged

Update/correct toolpad repository links in package.json #4113

merged 3 commits into from
Sep 18, 2024

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Sep 18, 2024

Use shorthand as per https://docs.npmjs.com/cli/v10/configuring-npm/package-json#repository
Add directory property to each

@Janpot Janpot changed the title Update toolpad repository links in package.json Update/correct toolpad repository links in package.json Sep 18, 2024
@Janpot Janpot mentioned this pull request Sep 18, 2024
Merged
@Janpot Janpot added the scope: code-infra Specific to the core-infra product label Sep 18, 2024
oliviertassinari
oliviertassinari reviewed Sep 18, 2024
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different from the other package.json, but fair, it works as well.

@Janpot Janpot marked this pull request as ready for review September 18, 2024 10:02
@Janpot Janpot requested a review from a team September 18, 2024 10:03
@Janpot Janpot merged commit 529db0f into mui:master Sep 18, 2024
13 checks passed
@Janpot Janpot deleted the repo-links branch September 18, 2024 15:41
oliviertassinari added a commit that referenced this pull request Oct 2, 2024
@oliviertassinari
[core] Make git repo easier to go to from IDE
d7fa8e2 
A follow-up on #4113. I was considering
which path to standardize in all the repos. In the end, between the two options,
having the full URL seems easier to open from the IDE.
So, why not be more verbose and match the other repos.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@apedroferreira apedroferreira apedroferreira approved these changes

Assignees
No one assigned
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Janpot @oliviertassinari @apedroferreira