[PageContainer] Avoid React invalid props warning #4189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| expect(within(breadcrumbs).getByText('World')).toBeTruthy(); | ||
| }); | ||
|
|
||
| // TODO: Remove in the next major version |
There was a problem hiding this comment.
Should we remove it in the next minor itself and not wait for a major? Perhaps breaking changes are okay to be made in a minor while the project is in beta
There was a problem hiding this comment.
sure, but it's not even in the current minor yet
bharatkashyap
approved these changes
Oct 7, 2024
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
apedroferreira
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid spreading these props to the root element
Closes #4184