Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core][PageContainer] Do not spread PageContainer title to child Container #4504

Merged
merged 1 commit into from
Dec 3, 2024
Merged

[core][PageContainer] Do not spread PageContainer title to child Container #4504

merged 1 commit into from
Dec 3, 2024

Conversation

christiancookbuzz
Copy link
Contributor

  • I've read and followed the contributing guide on how to create great pull requests.
  • I've updated the relevant documentation for any new or updated feature.
  • I've linked relevant GitHub issue with "Closes #".
  • I've added a visual demonstration in the form of a screenshot or video.

Closes #4452.

@Janpot Janpot added bug 🐛 Something doesn't work component: PageContainer labels Dec 3, 2024
Janpot
Janpot approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks 👍

@apedroferreira apedroferreira merged commit e1d76c0 into mui:master Dec 3, 2024
14 of 15 checks passed
@christiancookbuzz christiancookbuzz deleted the fix/4452-page-container-title branch December 4, 2024 08:52
@mkarajohn
Copy link

Nice, when can we expect this to be released?

@christiancookbuzz
Copy link
Contributor Author

@mkarajohn it looks like it will be landing in v0.11.0 soon: #4536

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Janpot Janpot Janpot approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: PageContainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PageContainer] Setting title prop manually gives all children title tooltip
4 participants
@christiancookbuzz @mkarajohn @Janpot @apedroferreira