Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Lint markdown #675

Merged
merged 6 commits into from
Jul 21, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jul 20, 2022

I was looking for a small change to make to test what the contribution workflow looks like when proposing a change from a fork for the community. I have found mui/material-ui#30395 to bring.

https://deploy-preview-675--mui-toolpad-docs.netlify.app/toolpad/getting-started/setup/

@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jul 20, 2022
@@ -0,0 +1,30 @@
{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1,4 +1,4 @@
# Getting started
# Tutorial
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because:

Screenshot 2022-07-20 at 23 47 48

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jul 20, 2022

The potential issues with community PRs:

  • "ci/circleci: docker" failing
  • render.com previews not generated

@Janpot
Copy link
Member

Janpot commented Jul 21, 2022

👍 Good idea

@oliviertassinari oliviertassinari merged commit bbcb43c into mui:master Jul 21, 2022
@oliviertassinari oliviertassinari deleted the lint-markdown-in-the-ci branch July 21, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants