Fix hidden tooltips issue in code editor #680
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://toolpad-pr-680.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cbd7pq0ivq00lqpgk07g. |
oliviertassinari
requested a deployment
to
fix-split-pane-overflow - toolpad-db PR #680
Render
Abandoned
|
This doesn't fix the problem at the root, we'll still see the issue in dialogs:
There may be legitimate reasons to have the editor nested in a container with hidden overflow. Isn't there a way we can make |
|
Oh, good catch, I will take a look 🙇 |
|
Closing as per #682 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the issue of tooltip being hidden. Tested other usages of split pane all seems still fine, however I'm not really sure what was meant by split pane overflow being hidden 🤔 I'm trying to think of a reasons but can't come up with anything, for me it seems logical that the consumer would be controlling overflow 🤔