Skip to content

Add EnableObject #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add EnableObject #148

wants to merge 6 commits into from
+38 −2

Conversation

cielavenir
Copy link

@cielavenir cielavenir commented Feb 8, 2024 •
edited
Loading

  • Adds EnableObject and EnableLink APIs. A customer needs them to reset itl state partially. Corresponding tasks are already implemented in our planningcommon.

    • But we should add the API to master to avoid the name collision in the future.

  • Grab/Release json had trailing commas. ujson.loads() seems ignoring them, but let's fix them as well. fixed by Fix JSON strings #159

@cielavenir
Copy link
Author

@kanbouchou any comments? or could you approve?

@cielavenir
Copy link
Author

b8449f4 was pointed out by the customer. we would need to have better review process. /cc @ntohge @ziyan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdiankov rdiankov Awaiting requested review from rdiankov

@kanbouchou kanbouchou Awaiting requested review from kanbouchou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cielavenir