Properly reset the autocomplete anchor when the popup closes

fixes #305
mujx · Jul 15, 2018 · 21185a4 · 21185a4
1 parent fde066e
commit 21185a4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/src/SuggestionsPopup.cpp b/src/SuggestionsPopup.cpp
@@ -9,8 +9,8 @@
 #include <QPainter>
 #include <QStyleOption>
 
-constexpr int PopupHMargin    = 5;
-constexpr int PopupItemMargin = 4;
+constexpr int PopupHMargin    = 4;
+constexpr int PopupItemMargin = 3;
 
 PopupItem::PopupItem(QWidget *parent)
   : QWidget(parent)
@@ -23,6 +23,8 @@ PopupItem::PopupItem(QWidget *parent)
         topLayout_ = new QHBoxLayout(this);
         topLayout_->setContentsMargins(
           PopupHMargin, PopupItemMargin, PopupHMargin, PopupItemMargin);
+
+        setSizePolicy(QSizePolicy::Preferred, QSizePolicy::Fixed);
 }
 
 void

diff --git a/src/TextInputWidget.cc b/src/TextInputWidget.cc
@@ -217,6 +217,7 @@ FilteredTextEdit::keyPressEvent(QKeyEvent *event)
                 auto word = cursor.selectedText();
 
                 if (cursor.position() == 0) {
+                        resetAnchor();
                         closeSuggestions();
                         return;
                 }
@@ -231,6 +232,7 @@ FilteredTextEdit::keyPressEvent(QKeyEvent *event)
 
                         emit showSuggestions(query());
                 } else {
+                        resetAnchor();
                         closeSuggestions();
                 }
 

diff --git a/src/dialogs/PreviewUploadOverlay.cc b/src/dialogs/PreviewUploadOverlay.cc
@@ -70,7 +70,7 @@ PreviewUploadOverlay::init()
                 winsize = window->frameGeometry().size();
                 center  = window->frameGeometry().center();
         } else {
-                nhlog::ui()->warn("unable to load the retrieve MainWindow's size");
+                nhlog::ui()->warn("unable to retrieve MainWindow's size");
         }
 
         fileName_.setText(QFileInfo{filePath_}.fileName());