Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make banner-background div tag for Modal #185

Merged
merged 1 commit into from
Mar 30, 2022
Merged

feat: make banner-background div tag for Modal #185

merged 1 commit into from
Mar 30, 2022

Conversation

minsoftk
Copy link
Contributor

when clicked Profile Icon, SearchBox is also activated.
so make new div Banner background Portal.

Issue Number

#178

Proposed Changes

  • 같은 Portal을 공유하고 있어 프로필 아이콘을 클릭했을 때, 검색창이 보이는 z-index 문제가 있었다.
  • 새로운 Banner-background 포탈을 만들어줬다. 검색창이 열릴 때, Banner-background가 열리도록 설정.

@minsoftk
feat: make banner-background div tag for Modal
feadb2a 
when clicked Profile Icon, SearchBox is also activated.
so make new div Banner background Portal.
@minsoftk minsoftk added bug Something isn't working problem problem labels Mar 30, 2022
@minsoftk minsoftk added this to the Sprint3 milestone Mar 30, 2022
@minsoftk minsoftk self-assigned this Mar 30, 2022
@ywc8851 ywc8851 merged commit 3a6befb into mukdaejang:develop Mar 30, 2022
@ywc8851
Copy link
Contributor

ywc8851 commented Mar 30, 2022

고생하셨습니다 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@minsoftk minsoftk

Labels
bug Something isn't working problem problem
Projects
None yet
Milestone
Sprint3
Development

Successfully merging this pull request may close these issues.
2 participants
@minsoftk @ywc8851