feat: get review data from firestore and transform data #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- jongbin added same image in images array and that makes error
- create getImages function to get multiple images - create reformPromiseAllSettled function to reformat data
- request review data by post data - use ReviewScoreImg component(face) - calc and filter by score - render image and content - modify review style
- apply default parameter to empty array
|
리뷰가 이제 잘 나오겠네요!! 고생했어요 형 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#166
Proposed Changes
@JJongBin added same image in images array and that makes error
add promise & promiseSettled type
create getImages function to get multiple images
create reformPromiseAllSettled function to reformat data
request review data by post data
use ReviewScoreImg component(face)
calc and filter by score
render image and content
modify detail page review layout center