-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
W-14237985 mtf #232
base: v1.1
Are you sure you want to change the base?
W-14237985 mtf #232
Conversation
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, it would be better to specify which XML tag to use wen you are saying:
"add a line for...." or "add the following line" > "add the xxx tag"
When you say "add the following line," it is not clear which line you are referring to.
I may not have marked this until later in the doc.
Also, try to limit the use of admonitions.
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/munit-extensions-maven-plugin-configuration.adoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, it would be better to specify which XML tag to use wen you are saying:
"add a line for...." or "add the following line" > "add the xxx tag"
When you say "add the following line," it is not clear which line you are referring to.
I may not have marked this until later in the doc.
Also, try to limit the use of admonitions.
Writer's Quality Checklist
Before merging your PR, did you: