Fix UTF-8 control encoding support on Win FTP #362
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a basic change to the FtpAbstractConnectionProvider class because I've experienced an issue on UTF-8 support for files names (the "path" property we set for the Write operation).
When I send filenames with Japanese characters to a Windows based FTP server, they get converted in some placeholder characters (probably ASCII), even if settings the Control Encoding to UTF-8.
Searching online I found this Stackoverflow question and there also a possible solution.
I implemented this in a custom Java class and I did several tests on Win FTP servers and it fixes the issue; I tried also if it corrupts interaction with Unix FTP, but it seems not.
I already have a ticket opened to MuleSoft Support; we tried together, using a POC project, using my custom FTP client class implementation and it was working.
With the connector instead there was no way to make it work correctly; we tried also setting the -Dmule.encoding=UTF-8 but with no success. I tried with different connector versions: 1.7.0, 1.71, 1.8.0, 1.8.1 and 1.8.2.
I think this could be a possible solution to solve the problem, at least when we set the control encoding to UTF-8.
Hi, thank you for your work. We understand that you want to merge your changes and move on from this issue, but we also want to maintain the safety, readability, and testability of our code. Because of this, we kindly ask that you confirm that you have fulfilled the prerequisites for each category of activity before merging your changes.
If the Pull Request has a dependency update:
For ALL the Releases:
NOTE: (applies only for Core-Connectors connectors and modules) The release process ends when you merge the pull request that updates the support branch to the new snapshot, please don't forget to do this.
Patch Version:
Minor Version:
Major Version: