W-17475148: Simple type params handler not handling certain expression param values #14113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
elrodro83
commented
Jan 2, 2025
elrodro83
commented
- Addendum
param values * Addendum
asanguinetti
requested changes
Jan 2, 2025
Comment on lines
46
to
49
| protected boolean isExpressionValue(CreateParamBeanDefinitionRequest request) { | ||
| return request.getParam().getValue().isLeft(); | ||
| return request.getParam().getValue().isLeft() | ||
| || isContent(request.getParam().getModel()); | ||
| } |
There was a problem hiding this comment.
There is something that I don't understand here. The method name is isExpressionValue and we are changing it so that static values are also considered as expressions if the parameter is a content parameter?
Maybe I'm getting it wrong, but from the test it looks like it.
Are we sure this is the right place to add the "if"? or at least maybe we need a good comment here.
asanguinetti
approved these changes
Jan 2, 2025
|
SonarQube Quality Gate
|
elrodro83
added a commit
that referenced
this pull request
Jan 2, 2025
…n param values (#14113) * Addendum
elrodro83
added a commit
that referenced
this pull request
Jan 2, 2025
…n param values (#14113) * Addendum
elrodro83
added a commit
that referenced
this pull request
Jan 2, 2025
…n param values (#14113) * Addendum
elrodro83
added a commit
that referenced
this pull request
Jan 2, 2025
param values (#14113) * Addendum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.