Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove forwarded ports code #5074

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Remove forwarded ports code #5074

merged 4 commits into from
Sep 5, 2023

Conversation

faern
Copy link
Member

@faern faern commented Aug 30, 2023

We no longer support forwarding ports over the VPN tunnel. So the app can stop parsing the ports in the device data type. We can also stop warning the users on logout if they have forwarded ports (because they by definition can't have that, so it's a dead code path)

Fixes DES-224, DES-223


This change is Reviewable

@linear
Copy link

linear bot commented Aug 30, 2023

DES-224 Remove logic around forwarded ports

As of 1st of June we're removing support for port forwarding.

If a user has forwarded ports we'll show a message informing them about it when they log out/remove a device. This logic and these messages can now be removed. We also store the ports in the daemon and communicate them over the managements interface. All logic around forwarded ports should be removed.

@faern faern force-pushed the remove-forwarded-ports-code branch from 87304fd to 5fff421 Compare August 31, 2023 08:08
@linear
Copy link

linear bot commented Aug 31, 2023

DES-223 App GUI freezes when user logs out after device has been revoked through web UI

The App GUI hangs if a device has been revoked from the manage account devices page and the user press "Log out" under Settings > Account.

Affected versions & platforms

  • The bug was found and reproduced on Linux (Fedora Workstation 38) using the latest Beta build (2023.4_beta1) as well as the latest commit on main.
  • The bug was reproduced on MacOS (the test computer) on the last stable release of Mullvad VPN (2023.3)

@faern faern force-pushed the remove-forwarded-ports-code branch from 5fff421 to cfca898 Compare August 31, 2023 13:40
@faern faern force-pushed the remove-forwarded-ports-code branch from cfca898 to 95dd941 Compare September 1, 2023 11:29
@faern faern marked this pull request as ready for review September 1, 2023 11:29
Copy link
Member

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 25 of 36 files at r1, 1 of 4 files at r4, all commit messages.
Reviewable status: 26 of 43 files reviewed, all discussions resolved

Copy link
Member

@raksooo raksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r3, 1 of 1 files at r5.
Reviewable status: 38 of 43 files reviewed, all discussions resolved

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android code :lgtm:

Probably unrelated to this PR, but when testing this (still ongoing) my device didn't get revoked when expected. Probably an API issue. Investigating right now...

Reviewed 22 of 36 files at r1, 2 of 4 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: 42 of 43 files reviewed, all discussions resolved

@faern faern force-pushed the remove-forwarded-ports-code branch from cc1614b to b59bb12 Compare September 4, 2023 09:06
Copy link
Member

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 4 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@faern faern force-pushed the remove-forwarded-ports-code branch from b59bb12 to 057c2e9 Compare September 5, 2023 09:27
@faern faern merged commit 3b7ddae into main Sep 5, 2023
37 checks passed
@faern faern deleted the remove-forwarded-ports-code branch September 5, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants