-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove forwarded ports code #5074
Conversation
DES-224 Remove logic around forwarded ports
As of 1st of June we're removing support for port forwarding. If a user has forwarded ports we'll show a message informing them about it when they log out/remove a device. This logic and these messages can now be removed. We also store the ports in the daemon and communicate them over the managements interface. All logic around forwarded ports should be removed. |
87304fd
to
5fff421
Compare
DES-223 App GUI freezes when user logs out after device has been revoked through web UI
Affected versions & platforms
|
5fff421
to
cfca898
Compare
cfca898
to
95dd941
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 25 of 36 files at r1, 1 of 4 files at r4, all commit messages.
Reviewable status: 26 of 43 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 11 of 11 files at r3, 1 of 1 files at r5.
Reviewable status: 38 of 43 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably unrelated to this PR, but when testing this (still ongoing) my device didn't get revoked when expected. Probably an API issue. Investigating right now...
Reviewed 22 of 36 files at r1, 2 of 4 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: 42 of 43 files reviewed, all discussions resolved
cc1614b
to
b59bb12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 4 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
b59bb12
to
057c2e9
Compare
We no longer support forwarding ports over the VPN tunnel. So the app can stop parsing the ports in the device data type. We can also stop warning the users on logout if they have forwarded ports (because they by definition can't have that, so it's a dead code path)
Fixes DES-224, DES-223
This change is