Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static analysis tool mobsfscan #5480

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

albin-mullvad
Copy link
Collaborator

@albin-mullvad albin-mullvad commented Nov 22, 2023

This PR aims to add an action that runs the static analysis tool mobsfscan. It's currently not configured to fail on warnings since we first need to address those.

More info about the tool here: https://github.com/MobSF/mobsfscan


This change is Reviewable

Copy link

linear bot commented Nov 22, 2023

@albin-mullvad albin-mullvad force-pushed the add-static-analysis-tool-mobsfscan-droid-525 branch from e597217 to 139c319 Compare November 22, 2023 10:27
The action will currently not fail on warnings. That can
be configured after we've went through the warnings and
fixed or suppressed them.
@albin-mullvad albin-mullvad force-pushed the add-static-analysis-tool-mobsfscan-droid-525 branch from 139c319 to 789201d Compare November 22, 2023 10:31
@albin-mullvad albin-mullvad self-assigned this Nov 22, 2023
@albin-mullvad albin-mullvad added the Android Issues related to Android label Nov 22, 2023
@albin-mullvad albin-mullvad marked this pull request as ready for review November 22, 2023 10:35
Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@sabercodic sabercodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@sabercodic sabercodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@albin-mullvad albin-mullvad merged commit 1e19403 into main Nov 22, 2023
4 checks passed
@albin-mullvad albin-mullvad deleted the add-static-analysis-tool-mobsfscan-droid-525 branch November 22, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants