Handle Device revoked on connect screen

[Rawa]

This PR handles the event of a device being revoked on the Connect screen, a regression from migrating to compose navigation. It also makes sure that we properly logout the user when "Go to login" is pressed in DeviceRevoked screen.

---

This change is 

[linear]

DROID-600 Device Revoked is not handled on ConnectScreen

[Pururun]

Reviewed 2 of 2 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/DeviceRevokedViewModel.kt line 50 at r2 (raw file):

            )

    private val _uiSideEffect = Channel<DeviceRevokedSideEffect>(1, BufferOverflow.DROP_OLDEST)

Any specific reason to use a Channel instead of a shared flow?

[Rawa]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/DeviceRevokedViewModel.kt line 50 at r2 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

Any specific reason to use a Channel instead of a shared flow?

Yes! We've migrated almost all SharedFlows over after discovering a navigational issue where the stream would miss messages. Basically a SharedFlow wont buffer if there is no subscribers whilst a channel may. You can read a bit more about it here:
Kotlin/kotlinx.coroutines#3002

[Rawa]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/DeviceRevokedViewModel.kt line 50 at r2 (raw file):

Previously, Rawa (David Göransson) wrote…

Yes! We've migrated almost all SharedFlows over after discovering a navigational issue where the stream would miss messages. Basically a SharedFlow wont buffer if there is no subscribers whilst a channel may. You can read a bit more about it here:
Kotlin/kotlinx.coroutines#3002

Clarifiycation: All uiSideEffect sharedflows has been migrated over.

[Pururun]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Rawa)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/DeviceRevokedViewModel.kt line 50 at r2 (raw file):

Previously, Rawa (David Göransson) wrote…

Clarifiycation: All uiSideEffect sharedflows has been migrated over.

Ah right I had missed that we had migrated over those.

[Pururun]

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved