Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gradle and agp #6608

Closed
wants to merge 3 commits into from
Closed

Conversation

albin-mullvad
Copy link
Collaborator

@albin-mullvad albin-mullvad commented Aug 13, 2024

This PR aims to bump gradle to 8.9 and agp to 8.5.2.


This change is Reviewable

Copy link

linear bot commented Aug 13, 2024

@albin-mullvad albin-mullvad force-pushed the update-gradle-and-agp-droid-1112 branch 2 times, most recently from 41d2670 to 2bd2557 Compare August 13, 2024 12:55
@albin-mullvad albin-mullvad added the Android Issues related to Android label Aug 13, 2024
@albin-mullvad albin-mullvad self-assigned this Aug 13, 2024
@albin-mullvad albin-mullvad marked this pull request as ready for review August 13, 2024 13:15
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@albin-mullvad albin-mullvad force-pushed the update-gradle-and-agp-droid-1112 branch from c1ba05f to 82e51a7 Compare August 13, 2024 14:35
niklasberglund
niklasberglund previously approved these changes Aug 14, 2024
Copy link
Collaborator

@niklasberglund niklasberglund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 5 of 9 files reviewed, all discussions resolved

@albin-mullvad albin-mullvad force-pushed the update-gradle-and-agp-droid-1112 branch from a3604ca to 9b3345a Compare August 15, 2024 15:11
Also:
* Enables gradle plugin lint check.
* Documents gradle dependency lint check.
* Removes experimental lint configuration.
@albin-mullvad albin-mullvad force-pushed the update-gradle-and-agp-droid-1112 branch from 9b3345a to 3de71ad Compare August 16, 2024 07:28
@albin-mullvad
Copy link
Collaborator Author

Putting on hold to prioritize some more important work with the goal of continuing in a week or two.

@albin-mullvad albin-mullvad added the On hold Means the PR is paused for some reason. No need to review it for now label Aug 16, 2024
@albin-mullvad
Copy link
Collaborator Author

This will partially be done in #6702 and partially in an upcoming PR when we've figured out how to handle all the newly reported CVE:s by the gradle owasp dependency check plugin.

@albin-mullvad albin-mullvad deleted the update-gradle-and-agp-droid-1112 branch September 23, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android On hold Means the PR is paused for some reason. No need to review it for now
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants