-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing log rotation test #6936
Fix failing log rotation test #6936
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rablador)
ios/MullvadLogging/LogFileOutputStream.swift
line 78 at r1 (raw file):
} /// Waits for write operations to finish by issuing a synchronous closure.
Could do with explaining it should only be used in testing.
ios/MullvadVPN.xcodeproj/project.pbxproj
line 2500 at r1 (raw file):
children = ( 44B02E3A2BC5732D008EDF34 /* LoggingTests.swift */, 7AA513852BC91C6B00D081A4 /* LogRotationTests.swift */,
Thanks, Xcode.
e23480f
to
20ae676
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pinkisemils)
ios/MullvadLogging/LogFileOutputStream.swift
line 78 at r1 (raw file):
Previously, pinkisemils (Emīls Piņķis) wrote…
Could do with explaining it should only be used in testing.
Done.
ios/MullvadVPN.xcodeproj/project.pbxproj
line 2500 at r1 (raw file):
Previously, pinkisemils (Emīls Piņķis) wrote…
Thanks, Xcode.
No, I did that. We keep files ordered alphabetically, and these werent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 4 files reviewed, all discussions resolved
ios/MullvadVPN.xcodeproj/project.pbxproj
line 2500 at r1 (raw file):
Previously, rablador (Jon Petersson) wrote…
No, I did that. We keep files ordered alphabetically, and these werent.
Oh, cool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved
20ae676
to
9f866a0
Compare
🚨 End to end tests failed. Please check the failed workflow run. |
The test
testRotatingActiveLogWhenSizeLimitIsExceeded
has been failing on the CI for a while. This PR enables forced synchronization of the asynchronous writes in that tests and similar to it.This change is