Upload instrumentation report regardless if tests failed

[niklasberglund]

Upload instrumentation test report no matter whether tests failed or ran successfully. Before it not uploaded if tests fail because by default a step's if have a successful() condition steps following a failing test not to run.

---

This change is 

[linear]

DROID-1460 Instrumentation test report not uploaded when tests fail

[Rawa]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @niklasberglund)

---

.github/workflows/android-app.yml line 480 at r1 (raw file):

      - name: Upload instrumentation report (${{ matrix.test-type }})
        uses: actions/upload-artifact@v4
        if: always() && matrix.test-repeat != 0

What is always(), just true? I don't follow how this change aligns with the name of the PR.

[niklasberglund]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Rawa)

---

.github/workflows/android-app.yml line 480 at r1 (raw file):

Previously, Rawa (David Göransson) wrote…

What is always(), just true? I don't follow how this change aligns with the name of the PR.

GitHub Actions does some magic with status checks in if conditions. If no status check is specified it will default to success() and the the step will only run if previous steps are successful. With always() this step will run even if previous steps failed.

https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions#status-check-functions

[Rawa]

Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

---

.github/workflows/android-app.yml line 480 at r1 (raw file):

Previously, niklasberglund (Niklas Berglund) wrote…

GitHub Actions does some magic with status checks in if conditions. If no status check is specified it will default to success() and the the step will only run if previous steps are successful. With always() this step will run even if previous steps failed.

https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions#status-check-functions

😳

[Rawa]

Reviewable status: complete! all files reviewed, all discussions resolved

---

.github/workflows/android-app.yml line 480 at r1 (raw file):

Previously, Rawa (David Göransson) wrote…

😳

👍

[Rawa]

Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved