Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always restart daemon when full-disk access message has been shown #7189

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

dlon
Copy link
Member

@dlon dlon commented Nov 18, 2024


This change is Reviewable

@dlon dlon requested a review from hulthe November 18, 2024 10:07
@dlon dlon force-pushed the fix-macos-restart-daemon-on-fda-warn branch from 2710618 to fe6a4df Compare November 18, 2024 10:08
hulthe
hulthe previously approved these changes Nov 18, 2024
Copy link
Contributor

@hulthe hulthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

hulthe
hulthe previously approved these changes Nov 19, 2024
Copy link
Contributor

@hulthe hulthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

raksooo
raksooo previously approved these changes Nov 20, 2024
Copy link
Member

@raksooo raksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dlon)


desktop/packages/mullvad-vpn/src/main/index.ts line 749 at r4 (raw file):

    this.tunnelState.handleNewTunnelState(await this.daemonRpc.getState());
    if (newState.state === 'error' && newState.details) {
      if (newState.details.cause === ErrorStateCause.needFullDiskPermissions) {

Nit: How about this instead?

if (newState.state === 'error' && newState.details?.cause === ErrorStateCause.needFullDiskPermissions) {

@dlon dlon dismissed stale reviews from raksooo and hulthe via 7a55043 November 20, 2024 08:37
@dlon dlon force-pushed the fix-macos-restart-daemon-on-fda-warn branch 2 times, most recently from 7a55043 to 33a5492 Compare November 20, 2024 08:56
raksooo
raksooo previously approved these changes Nov 20, 2024
Copy link
Member

@raksooo raksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dlon)

@dlon dlon force-pushed the fix-macos-restart-daemon-on-fda-warn branch 3 times, most recently from 762d753 to c75f753 Compare November 20, 2024 09:23
Copy link
Member

@raksooo raksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r8, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@hulthe hulthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r6, 1 of 1 files at r8, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dlon dlon force-pushed the fix-macos-restart-daemon-on-fda-warn branch from c75f753 to 13aba42 Compare November 21, 2024 07:04
@dlon dlon merged commit d118592 into main Nov 21, 2024
11 checks passed
@dlon dlon deleted the fix-macos-restart-daemon-on-fda-warn branch November 21, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants