Fix npm run build-x86
command in nsventforwarder
#7220
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue introduced in #7211 where a an extra dash (
-
) snuck into thebuild-x86
npm command in thensventforwarder
workspace. This messed up the variable substitution, which tripped upcp
because we provided it with a nonsensical path.build-x86
:cp ${CARGO_TARGET_DIR:--../../../target}
build-x86
:cp ${CARGO_TARGET_DIR:-../../../target}
The consequence of this is that we can not package the
x86
-version of the macOS app, which subsequently disallows us from producing universal installers.I've double-checked that this PR actually fixes the problem, and here is the proof:
Sorry for the inconvenience 👉 👈 🥺
This change is