Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Add installer downloader and in-app upgrades backend #7583

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from

Conversation

dlon
Copy link
Member

@dlon dlon commented Feb 3, 2025

This PR aims to introduce a minimal installer as well as most of the functionality for in-app upgrades (except UI). This is still a work in progress.

The main things that are missing:

  • Obtain verified version info from the Mullvad API
  • Implement UI correctly/fully
  • Packaging/build scripts

The planned native module for the Electron frontend is not in scope for this PR.

Close DES-1685
Close DES-1684
Close DES-1641
Close DES-1640
Close DES-1571


This change is Reviewable

@dlon dlon requested a review from Serock3 February 3, 2025 14:41
@dlon dlon changed the title WIP - Installer downloader WIP - Add installer downloader and in-app upgrades backend Feb 3, 2025
@dlon dlon force-pushed the installer-downloader branch from 8bdac28 to bf3eeb4 Compare February 4, 2025 08:22
Copy link
Contributor

@Serock3 Serock3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get this warning when running cargo check

warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
package:   C:\Users\Sebastian\Documents\Programming\mullvad\installer-downloader\Cargo.toml
workspace: C:\Users\Sebastian\Documents\Programming\mullvad\Cargo.toml

Is the opt level specified in installer-downloader being overwritten by the workspace level?

Copy link
Contributor

@Serock3 Serock3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess convert-assets.py is not supposed to be tracked in the repository, since we store the converted file, right?

@dlon
Copy link
Member Author

dlon commented Feb 6, 2025

I get this warning when running cargo check

warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
package:   C:\Users\Sebastian\Documents\Programming\mullvad\installer-downloader\Cargo.toml
workspace: C:\Users\Sebastian\Documents\Programming\mullvad\Cargo.toml

Is the opt level specified in installer-downloader being overwritten by the workspace level?

It isn't being correctly applied. This is noted in the toml file. I think it'll be replaced by a build script.

@dlon
Copy link
Member Author

dlon commented Feb 6, 2025

I guess convert-assets.py is not supposed to be tracked in the repository, since we store the converted file, right?

I think it should because it makes it easier to regenerate them if the SVGs are edited.

@dlon dlon force-pushed the installer-downloader branch from ec26088 to 15fb2cc Compare February 7, 2025 08:48
@dlon dlon force-pushed the installer-downloader branch from 2be7c7f to 6994be5 Compare February 23, 2025 13:13
@dlon dlon force-pushed the installer-downloader branch from 6994be5 to 4eef94d Compare February 23, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants