-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Add installer downloader and in-app upgrades backend #7583
base: main
Are you sure you want to change the base?
Conversation
8bdac28
to
bf3eeb4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get this warning when running cargo check
warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
package: C:\Users\Sebastian\Documents\Programming\mullvad\installer-downloader\Cargo.toml
workspace: C:\Users\Sebastian\Documents\Programming\mullvad\Cargo.toml
Is the opt level specified in installer-downloader
being overwritten by the workspace level?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess convert-assets.py
is not supposed to be tracked in the repository, since we store the converted file, right?
It isn't being correctly applied. This is noted in the toml file. I think it'll be replaced by a build script. |
I think it should because it makes it easier to regenerate them if the SVGs are edited. |
ec26088
to
15fb2cc
Compare
Notably, this means that the loader must run as a privileged user
Co-authored-by: Joakim Hulthe <joakim.hulthe@mullvad.net>
2be7c7f
to
6994be5
Compare
6994be5
to
4eef94d
Compare
This PR aims to introduce a minimal installer as well as most of the functionality for in-app upgrades (except UI). This is still a work in progress.
The main things that are missing:
The planned native module for the Electron frontend is not in scope for this PR.
Close DES-1685
Close DES-1684
Close DES-1641
Close DES-1640
Close DES-1571
This change is