Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New lyrics plugins #17

Closed
wants to merge 4 commits into from
Closed

New lyrics plugins #17

wants to merge 4 commits into from

Conversation

multani
Copy link
Owner

@multani multani commented Nov 7, 2012

New lyrics plugins

onto added 4 commits November 7, 2012 19:10
@onto @multani
Sonata automatically fetches lyrics in a new thread.
e5a966d 
Before, the lyric plugin had to do it by itself, which means *each*
lyric plugins had to do it by themselves.
Now, the plugin code is launched into a new thread, not matter what.
@onto @multani
Add additional "save lyric location" location.
ea7a84e
@onto @multani
Log which plugin downloaded lyrics
4f038ee
@onto @multani
Add new (alltexts.ru, AZLyrics.com, lyricstime.com, megalyrics.ru) ly…
c638de9 
…ric plugins.
@multani
Copy link
Owner Author

multani commented Nov 16, 2012

I don't really want to ship several lyrics plugin directly into Sonata: one, which does most of the job, and works, should be enough in my opinion.
And I can't test all those plugins correctly at the moment, my Internet connection kind of sucks...

Somewhere on the Internet, there are a féw repositories named "sonata-plugins", I'm keen to include on of those plugins directly into Sonata, and the rest into this additional plugins repository, and work something so it's easier to deal with those extra plugins. It's especially true since all those plugins raelly share the same structure, and I guess, could be simplified by factoring out even more similar code.

So, my proposition would be:

  1. include ONE, good enough, working, lyrics plugin. Lyricswiki seems fine to me, if it works. Make this plugin nice and clean so it's a kind of "model" for other people who wants to build extra lyrics plugin.
  2. work something new to support external plugins (plugins which are NOT shipped with Sonata) so that it's easy to use those plugins into Sonata. This is a good opportunity to improve the plugin system itself...
  3. add all the additional plugins into the (a?) new sonata-plugins repository and publish it on the Internet.

What do you think?

@onto
Copy link
Contributor

onto commented Nov 24, 2012

  1. I agree, that one best plugin better than "a lot of" ordinary plugins.
  2. Something like "add plugin" in settings? That's good idea.
  3. Agree

@multani
Copy link
Owner Author

multani commented Nov 25, 2012

  1. something like that yes. I have a few ideas already. I'm going to open a ticket so we can discuss this there...

@multani
Copy link
Owner Author

multani commented Jan 3, 2013

Hi,

I merged part of those commits (the 2 first ones) into master. I took the new lyrics wiki plugin from our third commit and adapted it to Python 3 and made some changes inside.

I didn't merge the "new locations" commits, since it wasn't working (I guess you need to do the interpolation of artists and title, and to lookup the right lyric file afterwards).

As for the other plugins, you can actually drops them into ~/.config/sonata/plugins/ and they shoud be discoverable by Sonata.

@multani multani closed this Jan 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@multani @onto