Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build x86_64 thin wheel by default with py3.10 #438

Merged
merged 3 commits into from
Nov 3, 2021

Conversation

isuruf
Copy link
Collaborator

@isuruf isuruf commented Oct 31, 2021

No description provided.

@radarhere radarhere changed the title build x86_64 thin wheel by default with py3.10 Build x86_64 thin wheel by default with py3.10 Oct 31, 2021
@isuruf
Copy link
Collaborator Author

isuruf commented Oct 31, 2021

Ready for review.

Most important change here is that _PYTHON_HOST_PLATFORM and ARCHFLAGS are set so that universal2 wheels are not tried by default. This change is needed because python3.10 doesn't have a x86_64 only release and has only a universal2 build.

@matthew-brett
Copy link
Collaborator

Just to check my understanding - we need a way to use the PLAT variable to force the building of thin wheels? Here the idea is that the user can specify PLAT=x86_64 and then get a thin x86_64 wheel? But, they can also specify arm64 to get an ARM64 thin wheel?

Can you think of a test?

@isuruf
Copy link
Collaborator Author

isuruf commented Nov 1, 2021

Just to check my understanding - we need a way to use the PLAT variable to force the building of thin wheels? Here the idea is that the user can specify PLAT=x86_64 and then get a thin x86_64 wheel? But, they can also specify arm64 to get an ARM64 thin wheel?

Issue is that with python3.9 x86_64 installer, it built thin wheels by default, but with python3.10 universal2 installer
it tries to build universal2 wheels by default which is not what we want.

Yes, they can set PLAT=arm64 to get a ARM64 thin wheel without this PR. This PR adds the ability to build a thin wheel with 3.10

I'll think of a test

@rgommers
Copy link

rgommers commented Nov 3, 2021

LGTM. Can this be merged @matthew-brett? It's needed for MacPython/numpy-wheels#140

@matthew-brett matthew-brett merged commit 36294d4 into multi-build:devel Nov 3, 2021
@isuruf isuruf deleted the x86_64_thin branch November 6, 2021 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants