feat: memory multiaddrs #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 23, 2024
MarcoPolo
requested changes
Oct 25, 2024
transcoders.go
Outdated
| @@ -489,3 +489,23 @@ func validateHTTPPath(b []byte) error { | |||
| } | |||
| return nil // We can represent any byte slice when we escape it. | |||
| } | |||
|
|
|||
| var TranscoderMemory = NewTranscoderFromFunctions(memoryStB, memoryBtS, nil) | |||
There was a problem hiding this comment.
We should define and use a validation function
There was a problem hiding this comment.
I have added a validation function. It validates that byte slice is 8 bytes long so it can be converted to uint64 using big endian.
MarcoPolo
approved these changes
Oct 28, 2024
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a "revisit" of #106.
I have just rebased the old branch
feat/memorywith the current upstream. This PR also relates to other issue I've picked up on libp2p side libp2p/go-libp2p#2293