New SumStream function reads from io.Reader #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides a way to read from a stream instead of having to load a potentially large file into memory first.
warpfork
requested changes
Apr 6, 2021
sum.go
Outdated
| func Sum(data []byte, code uint64, length int) (Multihash, error) { | ||
| return SumStream(bytes.NewReader(data), code, length) |
There was a problem hiding this comment.
I'm afraid we should take the hit of some duplicated code here, in exchange for keeping this a single []byte handoff without reader indirections. We'd rather not add one or more allocations to all code which currently uses this function with smallish byte slices.
There was a problem hiding this comment.
Refactored to write []byte directly without wrapping in bytes.Reader, with minimal code dup.
warpfork
approved these changes
Apr 6, 2021
|
Thanks for adding this! It really connects the dots well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a way to read from a stream instead of having to load a potentially large file into memory first.
Addresses issue #15