Skip to content
This repository has been archived by the owner on Sep 3, 2021. It is now read-only.

fix: typing mappings #137

Merged
merged 1 commit into from
Dec 12, 2020
Merged

fix: typing mappings #137

merged 1 commit into from
Dec 12, 2020

Conversation

Gozala
Copy link
Contributor

@Gozala Gozala commented Dec 12, 2020

Fixes regression introduced by #131 due to incorrect type mappings.

P.S.: It was not caught by js-ipfs because import end up having any type

@Gozala
fix: typing mappings
55be00d 
Fixes regression introduced by #131 due to incorrect type mappings
@Gozala Gozala requested review from vmx and hugomrdias December 12, 2020 00:20
carsonfarmer
carsonfarmer approved these changes Dec 12, 2020
View reviewed changes
Copy link
Contributor

@carsonfarmer carsonfarmer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this'll fix my build issues!

Fixes #131

vmx
vmx approved these changes Dec 12, 2020
View reviewed changes
Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve by proxy as enough folks who know what they are doing said it works.

@vmx vmx merged commit f5839b9 into master Dec 12, 2020
@vmx vmx deleted the fix/typeings branch December 12, 2020 00:40
@vmx
Copy link
Member

vmx commented Dec 12, 2020

Thanks a lot @carsonfarmer and @Gozala. I've published a 1.1.4.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carsonfarmer carsonfarmer carsonfarmer approved these changes

@vmx vmx vmx approved these changes

@hugomrdias hugomrdias Awaiting requested review from hugomrdias

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gozala @vmx @carsonfarmer