fix: fix converting strings to IP addresses and back again #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial fix for the issues observed in the ipfs interop suite - windows seems to lose it's reference to the `results` variable during node startup, but only windows. Instead return the result from the scope in which is is created. A follow up will be needed to address the other windows problem which is the IP detection regex seems to stop working. Might be a bug in node I guess?
github-actions bot
pushed a commit
that referenced
this pull request
Sep 21, 2022
## [11.0.0](v10.5.0...v11.0.0) (2022-09-21) ### ⚠ BREAKING CHANGES * the `Multiaddr` class is now an interface ### Features * convert to interface ([#274](#274)) ([36de98f](36de98f)), closes [#202](#202) ### Bug Fixes * fix converting strings to IP addresses and back again ([#270](#270)) ([77f063a](77f063a))
|
🎉 This PR is included in version 11.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for the issues observed in the ipfs interop suite - windows seems to lose it's reference to the
resultsvariable during node startup, but only windows. Instead return the result from the scope in which is is created.A follow up will be needed to address the other windows problem which is the IP detection regex seems to stop working. Might be a bug in node I guess?