feat!: convert to interface #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Renames the `Multiaddr` class to `DefaultMultiaddr` - Exports `Multiaddr` as an interface The `multiaddr` function should be used to create new instances of `Multiaddr` (introduced in v9.0.0) instead of instantiating the `Multiaddr` class directly. This allows us to remove the `inspect` symbol from the interface and avoid use of `Object.defineProperty` which is very slow. BREAKING CHANGE: the `Multiaddr` class is now an interface
Member
Author
|
cc @wemeetagain |
wemeetagain
approved these changes
Sep 20, 2022
Contributor
wemeetagain
left a comment
wemeetagain
left a comment
There was a problem hiding this comment.
Hooray! the PR looks good to me
github-actions bot
pushed a commit
that referenced
this pull request
Sep 21, 2022
## [11.0.0](v10.5.0...v11.0.0) (2022-09-21) ### ⚠ BREAKING CHANGES * the `Multiaddr` class is now an interface ### Features * convert to interface ([#274](#274)) ([36de98f](36de98f)), closes [#202](#202) ### Bug Fixes * fix converting strings to IP addresses and back again ([#270](#270)) ([77f063a](77f063a))
|
🎉 This PR is included in version 11.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiaddrclass toDefaultMultiaddrMultiaddras an interfaceThe
multiaddrfunction (introduced in v9.0.0) should be used to create new instances ofMultiaddrinstead of instantiating theMultiaddrclass directly.This allows us to remove the
inspectsymbol from the interface and avoid use ofObject.definePropertywhich is very slow:Fixes: #202
BREAKING CHANGE: the
Multiaddrclass is now an interface