fix: return correct family from toOptions with dns4 MultiAddr #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tiAddr
When calling toOptions with a dns4 multiaddress, a MultiaddrObject is returned where the ip family is 6 instead of 4. This causes an issue where libp2p is unable to resolve the domain and dial the peer. This only appears to be an issue on some systems. It works on Mac OS but fails on for example Alpine Linux.
Example:
```const {multiaddr} = require("multiaddr")
console.log(multiaddr('/dns4/google.net/tcp/8000').toOptions())`
```
```
Object {family: 6, host: "google.net", transport: "tcp", port: 8000}
```
|
Can confirm the issue. Returning |
achingbrain
changed the title
MultiaddrObject when calling toOptions with dns4 Mul…MultiaddrObject when calling toOptions with dns4 MultiAddr
achingbrain
changed the title
MultiaddrObject when calling toOptions with dns4 MultiAddr
achingbrain
changed the title
|
Thanks! |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 7, 2022
## [10.3.3](v10.3.2...v10.3.3) (2022-07-07) ### Bug Fixes * return correct family from toOptions with dns4 MultiAddr ([#233](#233)) ([d3f8b05](d3f8b05))
|
🎉 This PR is included in version 10.3.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling toOptions with a dns4 multiaddress, a MultiaddrObject is returned where the ip family is 6 instead of 4. This causes an issue where libp2p is unable to resolve the domain and dial the peer. This only appears to be an issue on some systems. It works on Mac OS but fails on for example Alpine Linux.
Example: