Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default to https ports for dnsaddr addresses #258

Merged
merged 1 commit into from
Jul 7, 2022
Merged

fix: default to https ports for dnsaddr addresses #258

merged 1 commit into from
Jul 7, 2022

Conversation

achingbrain
Copy link
Member

Sometimes addresses are of the format /dnsaddr/domain/p2p/peer-id

When this is the case, default to tcp/443 for protocol/port.

@achingbrain
fix: default to https ports for dnsaddr addresses
88817c1 
Sometimes addresses are of the format `/dnsaddr/domain/p2p/peer-id`

When this is the case, default to tcp/443 for protocol/port.
@achingbrain achingbrain merged commit e8bcff7 into master Jul 7, 2022
@achingbrain achingbrain deleted the fix/default-to-https-ports-for-dnsaddr branch July 7, 2022 13:44
github-actions bot pushed a commit that referenced this pull request Jul 7, 2022
@semantic-release-bot
chore(release): 10.3.1 [skip ci]
45e6bf5 
## [10.3.1](v10.3.0...v10.3.1) (2022-07-07)

### Bug Fixes

* default to https ports for dnsaddr addresses ([#258](#258)) ([e8bcff7](e8bcff7))

### Dependencies

* **dev:** bump sinon from 13.0.2 to 14.0.0 ([#240](#240)) ([3c2eaba](3c2eaba))
@github-actions
Copy link

github-actions bot commented Jul 7, 2022

🎉 This PR is included in version 10.3.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

achingbrain added a commit that referenced this pull request Jul 7, 2022
@achingbrain
fix: use codes instead of strings for dnsaddr detection
1cdf00b 
This was missed from #258
@achingbrain achingbrain mentioned this pull request Jul 7, 2022
Merged
achingbrain added a commit that referenced this pull request Jul 7, 2022
@achingbrain
fix: use codes instead of strings for dnsaddr detection (#259)
d8431bf 
This was missed from #258
github-actions bot pushed a commit that referenced this pull request Jul 7, 2022
@semantic-release-bot
chore(release): 10.3.2 [skip ci]
2c733fa 
## [10.3.2](v10.3.1...v10.3.2) (2022-07-07)

### Bug Fixes

* use codes instead of strings for dnsaddr detection ([#259](#259)) ([d8431bf](d8431bf)), closes [#258](#258)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@achingbrain