Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix p2p addrs #45

Merged
merged 5 commits into from
Sep 3, 2017
Merged

Fix p2p addrs #45

merged 5 commits into from
Sep 3, 2017

Conversation

daviddias
Copy link
Member

@daviddias daviddias merged commit 28d8ce5 into master Sep 3, 2017
@daviddias daviddias deleted the fix-p2p-addrs branch September 3, 2017 08:19
@daviddias daviddias mentioned this pull request Sep 3, 2017
Closed
@multiformats multiformats deleted a comment from coveralls Sep 3, 2017
@mkg20001
Copy link
Contributor

mkg20001 commented Sep 5, 2017

p2p-websockets-star. Why the s?

@daviddias
Copy link
Member Author

Yeah, just realized you called it websocket-star when the repo was moved. We are fine with either, I picked websockets-star with the s because we always say the "WebSockets Transport" (for some reason). Wanna PR to remove it?

@mkg20001
Copy link
Contributor

mkg20001 commented Sep 5, 2017 •
edited
Loading

Yes

@mkg20001
Copy link
Contributor

mkg20001 commented Sep 5, 2017

PR: #46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dignifiedquire dignifiedquire dignifiedquire approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daviddias @mkg20001 @dignifiedquire