Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiformats not found in unpkg #234

Closed
garyrob opened this issue Dec 16, 2022 · 2 comments · Fixed by #235
Closed

Multiformats not found in unpkg #234

garyrob opened this issue Dec 16, 2022 · 2 comments · Fixed by #235
Assignees
@achingbrain

Comments

@garyrob
Copy link

garyrob commented Dec 16, 2022

The docs say to use <script src="https://unpkg.com/multiformats/dist/index.min.js"></script>. But it doesn't work in my HTML file and when I try to bring the URL up in a browser, I get "Cannot find "/dist/index.min.js" in multiformats@10.0.3".
@rvagg
Copy link
Member

rvagg commented Dec 19, 2022

@achingbrain is this a standard readme thing that got imported during the conversion to aegir? we're not distributing an index.min.js from here, although someone could import individual exports from unpkg.

achingbrain added a commit that referenced this issue Dec 19, 2022
@achingbrain
fix: build browser bundle
2535973 
Enable shipping a minified browser bundle.

Fixes #234
@achingbrain achingbrain mentioned this issue Dec 19, 2022
Merged
@achingbrain
Copy link
Member

Looks like building the minified bundle was disabled in 163d463 though I'm not sure why? I've opened #235 which enables it.

@rvagg rvagg closed this as completed in #235 Jan 2, 2023
rvagg pushed a commit that referenced this issue Jan 2, 2023
@achingbrain @rvagg
fix: build browser bundle
2ee6012 
Enable shipping a minified browser bundle.

Fixes #234
github-actions bot pushed a commit that referenced this issue Jan 2, 2023
@semantic-release-bot
chore(release): 11.0.0 [skip ci]
4b484bb 
## [11.0.0](v10.0.3...v11.0.0) (2023-01-02)

### ⚠ BREAKING CHANGES

* Make link.toJSON return a DAG-JSON link

### Features

* Make link.toJSON return a DAG-JSON link ([9e087d6](9e087d6))

### Bug Fixes

* build browser bundle ([2ee6012](2ee6012)), closes [#234](#234)
* list links of a block that _is a_ CID ([#226](#226)) ([c17673d](c17673d))

### Documentation

* fix typos in jsdoc comments ([a246054](a246054))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@achingbrain achingbrain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: build browser bundle multiformats/js-multiformats
3 participants
@rvagg @achingbrain @garyrob