feat: add hasCode to Digest #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To give a hint to tsc that a `MultihashDigest` has a specific code, add a disambiguator `hasCode` function. This lets us define functions that require a certain multihash code with type saftey.
achingbrain
commented
Sep 13, 2024
| @@ -1,7 +1,7 @@ | |||
| import { coerce } from '../bytes.js' | |||
| import * as Digest from './digest.js' | |||
|
|
|||
| const code = 0x0 | |||
| const code: 0x0 = 0x0 | |||
There was a problem hiding this comment.
This is necessary otherwise the type of code is derived as number and not 0 which means digestHasCode(hash, identity.code) hints that the type of hash is MultihashDigest<number> when we want it to be MultihashDigest<0x0>.
digestHasCode(hash, 0x0) works without this change but it'd be nice to be able to reuse identity.code.
rvagg
approved these changes
Sep 16, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Sep 16, 2024
## [13.3.0](v13.2.4...v13.3.0) (2024-09-16) ### Features * add hasCode to Digest ([#308](#308)) ([a5fbf61](a5fbf61))
|
🎉 This PR is included in version 13.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To give a hint to tsc that a
MultihashDigesthas a specific code, add a disambiguatorhasCodefunction.This lets us define functions that require a certain multihash code with type saftey.