feat: add support for webworkers #14
Conversation
| @@ -7,14 +7,14 @@ | |||
| "./src/crypto-sha1-2.js": "./src/crypto-sha1-2-browser.js" | |||
| }, | |||
| "scripts": { | |||
| "test": "aegir-test", | |||
| "test:browser": "aegir-test browser", | |||
| "test": "aegir-test --webworker", | |||
There was a problem hiding this comment.
So you are proposing to just run the tests in a webworker??
There was a problem hiding this comment.
Ah no, sorry this means run tests also in webworker, that's why it's not --env webworker.
There was a problem hiding this comment.
The tests now run three times, once in node, once in the browser without webworkers and once inside webworkers
There was a problem hiding this comment.
aegir could use an update to something like: --runtime=node, browser, webworker
There was a problem hiding this comment.
aegir could use a proper cli interface yes...but don't know when to do things like that...
| } else if (typeof self !== 'undefined') { | ||
| globalContext = self | ||
| } else { | ||
| return |
There was a problem hiding this comment.
shouldn't this throw an error?
There was a problem hiding this comment.
no, the throwing happens below
| @@ -7,14 +7,14 @@ | |||
| "./src/crypto-sha1-2.js": "./src/crypto-sha1-2-browser.js" | |||
| }, | |||
| "scripts": { | |||
| "test": "aegir-test", | |||
| "test:browser": "aegir-test browser", | |||
| "test": "aegir-test --webworker", | |||
There was a problem hiding this comment.
So you are proposing to just run the tests in a webworker??
Based on the work in #11 and #12