This repository has been archived by the owner on Oct 19, 2022. It is now read-only.
new multistream api #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddias
force-pushed
the
new-multistream-api
branch
4 times, most recently
from
62a267a
to
8addba0
Compare
|
@dignifiedquire could you CR, please ? :) |
yes sir david |
|
|
||
| ### silent - broadcast | ||
| multistream-select has one modes of operation: |
There was a problem hiding this comment.
Also maybe better, "has currently one mode of operation" as otherwise it sounds odd that you mention this explicitly if there is only one mode anyway
|
@diasdavid left some comments, also it would be nice if the coverage would at least stay above 90% ;) |
daviddias
force-pushed
the
new-multistream-api
branch
3 times, most recently
from
4e8ffd2
to
5fa2b9c
Compare
daviddias
force-pushed
the
new-multistream-api
branch
from
5fa2b9c
to
f27ce88
Compare
|
All CR applied. Coverage up to ~93%, ready for the merge :D |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also removes the 'silent' mode. Reason: It was never used or tested and it makes the code just way more complex and the API harder to explain. This is one of the reasons that this refactor, 1 year later is so valuable, because we now know well how multistream is used.