Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add /p2p-stardust #84

Merged
merged 1 commit into from
Jan 13, 2019
Merged

feat: Add /p2p-stardust #84

merged 1 commit into from
Jan 13, 2019

Conversation

mkg20001
Copy link
Contributor

This is part of the endeavor to replace ws-star with the newly created stardust protocol. See libp2p/js-libp2p-websocket-star#70 for a reference

Copy link

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

480 is already associated with http

This is part of the endeavor to replace ws-star with the newly created stardust protocol. See libp2p/js-libp2p-websocket-star#70 for a reference
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be allocated in multiformats/multicodec before merging here.

mkg20001 added a commit to mkg20001/multicodec that referenced this pull request Jan 12, 2019
This is part of the endeavor to replace ws-star with the newly created stardust protocol. See libp2p/js-libp2p-websocket-star#70 for a reference

Relates to multiformats/multiaddr#84 (review)
@mkg20001
Copy link
Contributor Author

@Stebalien Stebalien merged commit f3bb08e into multiformats:master Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants