Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BLS 12-381 g1 and g2 public key concatenated identifier #185

Merged
merged 2 commits into from
Sep 17, 2020

Conversation

tplooker
Copy link
Contributor

For certain signatures such as https://github.com/mattrglobal/bbs-signatures it is useful to have a single private key have a corresponding public key in both the G1 and G2 fields.

@OR13
Copy link
Contributor

OR13 commented Aug 1, 2020

Looking forward to using this representation.

@OR13
Copy link
Contributor

OR13 commented Sep 9, 2020

@rvagg @vmx can we get a review of this? let us know if we need to make any adjustments... the reason we need an encoding for both keys concatenated is to support w3c/vc-di-bbs#37

@vmx
Copy link
Member

vmx commented Sep 9, 2020

@OR13 could you please put it after ed25519-pub, we currently sort by code value (so that it's easier to spot if some value is already taken).

@tplooker
Copy link
Contributor Author

@vmx done

Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably should have put bls12_381* in the two-byte range, but it's hard to push this one away from this block now I suppose

@vmx
Copy link
Member

vmx commented Sep 17, 2020

we probably should have put bls12_381* in the two-byte range

It is in the 2-byte range. Everything > 0x80 is in the two-byte range.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants