Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update crate to edition 2021 #72

Merged
merged 1 commit into from
Dec 20, 2022
Merged

update crate to edition 2021 #72

merged 1 commit into from
Dec 20, 2022

Conversation

koushiro
Copy link
Contributor

  • update crate to edition 2021
  • update multihash to v0.18.0
  • update quickcheck to v1.0.3

close #41
close #49

@koushiro
update to edition 2021
0bfb2e4 
- update multihash to v0.18.0
- update quickcheck to v1.0.3
@koushiro
Copy link
Contributor Author

@mxinden PTAL

jxs
jxs reviewed Dec 17, 2022
View reviewed changes
Cargo.toml
@@ -1,7 +1,8 @@
[package]
authors = ["dignifiedquire <dignifiedquire@gmail.com>", "Parity Technologies <admin@parity.io>"]
description = "Implementation of the multiaddr format"
edition = "2018"
edition = "2021"
rust-version = "1.59.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious, why 1.59.0? The first version that supports the field is 1.56.0

Copy link
Contributor Author

@koushiro koushiro Dec 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because the MSRV of multihash-v0.18 is 1.59.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does ones MSRV need to be >= to ones dependencie's MSRV?

@jxs jxs mentioned this pull request Dec 17, 2022
Merged
thomaseizinger
thomaseizinger reviewed Dec 20, 2022
View reviewed changes
Cargo.toml
@@ -17,7 +18,7 @@ arrayref = "0.3"
byteorder = "1.3.1"
data-encoding = "2.1"
multibase = "0.9.1"
multihash = { version = "0.17", default-features = false, features = ["std", "multihash-impl", "identity"] }
multihash = { version = "0.18", default-features = false, features = ["std", "multihash-impl", "identity"] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be another breaking change across the entire Rust libp2p ecosystem. Unless this upgrade is a blocker for something, it would be nice if we could hold off releasing this until multiformats/rust-multihash#259 is actioned.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to upgrade to edition 2021 without having to bump this, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will be doing another breaking change with #70. #70 is needed among other things for better instrumentation of the IPFS network.

Given that we do a breaking change anyways, we might as well pack as much as possible into it, i.e. multihash v0.18.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#73 is also a breaking change, can we include that as-well? I don't have permissions to create a milestone in this repository but it might be worthwhile creating one so we can plan these things :)

mxinden
mxinden approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @koushiro!

Cargo.toml
@@ -17,7 +18,7 @@ arrayref = "0.3"
byteorder = "1.3.1"
data-encoding = "2.1"
multibase = "0.9.1"
multihash = { version = "0.17", default-features = false, features = ["std", "multihash-impl", "identity"] }
multihash = { version = "0.18", default-features = false, features = ["std", "multihash-impl", "identity"] }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will be doing another breaking change with #70. #70 is needed among other things for better instrumentation of the IPFS network.

Given that we do a breaking change anyways, we might as well pack as much as possible into it, i.e. multihash v0.18.

tests/lib.rs
fn arbitrary<G: Gen>(g: &mut G) -> Self {
let iter = (0..g.next_u32() % 128).map(|_| Proto::arbitrary(g).0);
fn arbitrary(g: &mut Gen) -> Self {
let iter = (0..u8::arbitrary(g) % 128).map(|_| Proto::arbitrary(g).0);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮 change needed is a lot smaller than anticipated. Thanks.

Cargo.toml
@@ -1,7 +1,8 @@
[package]
authors = ["dignifiedquire <dignifiedquire@gmail.com>", "Parity Technologies <admin@parity.io>"]
description = "Implementation of the multiaddr format"
edition = "2018"
edition = "2021"
rust-version = "1.59.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does ones MSRV need to be >= to ones dependencie's MSRV?

@mxinden mxinden merged commit fa7d7ca into multiformats:master Dec 20, 2022
@koushiro koushiro deleted the update-edition2021 branch December 20, 2022 08:29
@koushiro
Copy link
Contributor Author

Does ones MSRV need to be >= to ones dependencie's MSRV?

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger left review comments

@mxinden mxinden mxinden approved these changes

@jxs jxs jxs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@koushiro @jxs @thomaseizinger @mxinden