Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: mark Protocol as non_exhaustive #82

Merged
merged 3 commits into from
Mar 21, 2023
Merged

feat!: mark Protocol as non_exhaustive #82

merged 3 commits into from
Mar 21, 2023

Conversation

thomaseizinger
Copy link
Contributor

As an effort towards #71, mark Protocol as non_exhaustive. This allows us to add new variants without breaking downstream code.

I think matching on the Protocol is important, thus I chose to use non_exhaustive here over making it opaque.

@thomaseizinger thomaseizinger changed the title Mark Protocol as non_exhaustive feat! mark Protocol as non_exhaustive Mar 20, 2023
@thomaseizinger thomaseizinger changed the title feat! mark Protocol as non_exhaustive feat!: mark Protocol as non_exhaustive Mar 20, 2023
@thomaseizinger thomaseizinger changed the title feat!: mark Protocol as non_exhaustive feat!: mark Protocol as non_exhaustive Mar 20, 2023
mxinden
mxinden approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in favor of this change.

Is this a breaking change? If so, mind adding a changelog entry?

@thomaseizinger
Copy link
Contributor Author

I am in favor of this change.

Is this a breaking change? If so, mind adding a changelog entry?

I did that locally and forgot to push 🤦‍♂️

thomaseizinger
thomaseizinger commented Mar 21, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@thomaseizinger thomaseizinger requested a review from mxinden March 21, 2023 14:34
@mxinden mxinden merged commit 89deac2 into multiformats:master Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomaseizinger @mxinden