Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parity Codec bumps MSRV to 1.64.0 #306

Closed
mriise opened this issue Apr 29, 2023 · 4 comments
Closed

Parity Codec bumps MSRV to 1.64.0 #306

mriise opened this issue Apr 29, 2023 · 4 comments
Milestone

Comments

@mriise
Copy link
Contributor

mriise commented Apr 29, 2023

proc-macro-crate (dependency of parity-scale-codec-derive) has no patch number defined for toml_edit which made a recent patch to update winnow which bumps the MSRV.

PR: bkchr/proc-macro-crate#35

@mriise
Copy link
Contributor Author

mriise commented Apr 29, 2023

This is breaking the new MSRV check in CI for both #304 and #305

@thomaseizinger
Copy link
Contributor

Damn, when will people stop making MSRV breaking changes in patch releases. This makes me wonder whether we should retain parity-scale-codec as a dependency in here.

@thomaseizinger
Copy link
Contributor

I think the way forward here is to document (and test) that the MSRV for multihash only applies with all features disabled. That gives us control over this until we can remove parity-scale-codec from the library.

@vmx
Copy link
Member

vmx commented May 31, 2023

A MSRV bump was needed due to toml_datetime, which was then merged with #315. Hence I'm closing this issue as we are now at the MSRV of 1.64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants