Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose MultihashDigest trait in codetable #304

Merged
merged 1 commit into from
May 2, 2023
Merged

Expose MultihashDigest trait in codetable #304

merged 1 commit into from
May 2, 2023

Conversation

mriise
Copy link
Contributor

@mriise mriise commented Apr 29, 2023

Can't use any methods without exposing the trait implemented from deriving.

e.g. Code::try_from(0x12).digest(&[0xb0, 0xba])

@mriise mriise mentioned this pull request Apr 29, 2023
Closed
@mriise mriise requested review from thomaseizinger and vmx April 29, 2023 22:15
@thomaseizinger thomaseizinger added this to the v0.19 milestone May 2, 2023
vmx
vmx approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this while CI is not fully green, but the failure is tracked at #306 and will be fixed later.

@vmx vmx merged commit 50b43cd into master May 2, 2023
@vmx vmx deleted the code-table-trait branch May 2, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmx vmx vmx approved these changes

@thomaseizinger thomaseizinger Awaiting requested review from thomaseizinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.19
Development

Successfully merging this pull request may close these issues.
3 participants
@mriise @vmx @thomaseizinger