chore(deps): update parity-scale-codec requirement from 1.3.5 to 2.1.1

[dependabot]

Updates the requirements on parity-scale-codec to permit the latest version.

Commits

• See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[mxinden]

Where is parity-scale-codec used in conjunction with multihash? As far as I can tell, it is not used in:

• rust-libp2p multiaddr: https://github.com/libp2p/rust-libp2p/blob/29d969be340b610e19bf05661b731883f25e6821/misc/multiaddr/Cargo.toml#L19
• Substrate: https://github.com/paritytech/substrate/search?q=multihash+%3D

//CC @tomaka

[vmx]

@mxinden I guess you are asking as you think about removing it?

I don't know of any usage of parity-scale-codec. It wasn't specifically introduced for libp2p/parity related things.
It was once introduced by @dvc94ch. @dvc94ch do you use it somewhere?

[tomaka]

Nothing libp2p-related should use parity-scale-codec.

[dvc94ch]

it's an optional dependency to implement Encode/Decode for multihash. sunshine-protocol was using it to store references to ipfs blocks and other projects wanted this too. however I don't really know if anyone is using it at the moment and I really don't care much for blockchain anymore so...

[vmx]

Thanks for all your quick replies. It looks like no-one is really using this feature, so what do other think about just removing it.

As can be seen in this PR even if it's option, it needs some maintenance work. When we remove it, it doesn't anymore.

[mriise]

Removing this dep would also simplify #116 as it would be common sense to impl<const S: usize> parity_scale_codec::Encode for Multihash<S>. In reality it shouldn't be too hard, but it would be less work.

[mxinden]

#120 would remove the dependency all together. Let me know what you think.

[dependabot]

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.