Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iproute2: change backup mode (MP_PRIO) for active connections #158

Closed
1 of 2 tasks
matttbe opened this issue Feb 11, 2021 · 3 comments
Closed
1 of 2 tasks

iproute2: change backup mode (MP_PRIO) for active connections #158

matttbe opened this issue Feb 11, 2021 · 3 comments
Assignees
@dcaratti
Labels
enhancement iproute2

Comments

@matttbe
Copy link
Member

matttbe commented Feb 11, 2021 •
edited
Loading

Issue #51 added MP_PRIO support but this support cannot be validated with the current version of iproute2.

With iproute2, you can interact with MPTCP PM to add and remove addresses with different properties. But you cannot change these properties for active addresses. The idea would be to support ip mptcp endpoint change ADDRESS backup [on/off] or similar.

Once this support is added, emitting MP_PRIO can be validated with packetdrill.

  • iproute2: support a change mode
  • packetdrill validation
@matttbe matttbe mentioned this issue Feb 11, 2021
Closed
4 tasks
@dcaratti dcaratti self-assigned this Feb 25, 2021
@dcaratti
Copy link
Contributor

dcaratti commented Apr 8, 2021 •
edited
Loading

Issue #51 added MP_PRIO support but this support cannot be validated with the current version of iproute2.

With iproute2, you can interact with MPTCP PM to add and remove addresses with different properties. But you cannot change these properties for active addresses. The idea would be to support ip mptcp endpoint change ADDRESS backup [on/off] or similar.

Once this support is added, emitting MP_PRIO can be validated with packetdrill.

  • iproute2: support a change mode
  • packetdrill validation

@matttbe, I see that the current kernel is expecting address family + address (and optionally port number) for selecting which subflows should send the MP_PRIO, instead of 'id'. Is there a reason behind this? (if not, I can try to write a small patch for Linux that changes this)

@matttbe
Copy link
Member Author

matttbe commented Apr 8, 2021

As discussed at the last meeting:

Is there a reason behind this?

Probably we didn't think about adding support for the ID, we certainly focus on testing this with pm_nl where we already had the IP + port and we only implemented that.

But consistency is important, so yes please add support for that in the Linux kernel :)

fengguang pushed a commit to 0day-ci/linux that referenced this issue Nov 11, 2021
@dcaratti @intel-lab-lkp
mptcp: allow changing the "backup" bit by endpoint id
a55108f 
a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: multipath-tcp/mptcp_net-next#158
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
fengguang pushed a commit to 0day-ci/linux that referenced this issue Nov 18, 2021
@dcaratti @intel-lab-lkp
mptcp: allow changing the "backup" bit by endpoint id
cfb151b 
a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: multipath-tcp/mptcp_net-next#158
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Nov 19, 2021
@dcaratti @matttbe
mptcp: allow changing the "backup" bit by endpoint id
61df278 
a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: #158
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Nov 19, 2021
@dcaratti @matttbe
mptcp: allow changing the "backup" bit by endpoint id
cfb71d5 
a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: #158
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
jenkins-tessares pushed a commit that referenced this issue Nov 20, 2021
@dcaratti @jenkins-tessares
mptcp: allow changing the "backup" bit by endpoint id
56e5109 
a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: #158
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
jenkins-tessares pushed a commit that referenced this issue Nov 21, 2021
@dcaratti @jenkins-tessares
mptcp: allow changing the "backup" bit by endpoint id
778ad07 
a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: #158
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
jenkins-tessares pushed a commit that referenced this issue Nov 23, 2021
@dcaratti @jenkins-tessares
mptcp: allow changing the "backup" bit by endpoint id
a6091c7 
a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: #158
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Nov 23, 2021
@dcaratti @matttbe
mptcp: allow changing the "backup" bit by endpoint id
582088e 
a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: #158
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
jenkins-tessares pushed a commit that referenced this issue Nov 24, 2021
@dcaratti @jenkins-tessares
mptcp: allow changing the "backup" bit by endpoint id
3d1f56f 
a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: #158
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
jenkins-tessares pushed a commit that referenced this issue Nov 25, 2021
@dcaratti @jenkins-tessares
mptcp: allow changing the "backup" bit by endpoint id
4865413 
a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: #158
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
jenkins-tessares pushed a commit that referenced this issue Nov 26, 2021
@dcaratti @jenkins-tessares
mptcp: allow changing the "backup" bit by endpoint id
4fad79a 
a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: #158
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
jenkins-tessares pushed a commit that referenced this issue Nov 27, 2021
@dcaratti @jenkins-tessares
mptcp: allow changing the "backup" bit by endpoint id
dfac6b4 
a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: #158
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Nov 29, 2021
@dcaratti @matttbe
mptcp: allow changing the "backup" bit by endpoint id
9f4307c 
a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: #158
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
jenkins-tessares pushed a commit that referenced this issue Nov 30, 2021
@dcaratti @jenkins-tessares
mptcp: allow changing the "backup" bit by endpoint id
2a8f09f 
a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: #158
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
jenkins-tessares pushed a commit that referenced this issue Dec 1, 2021
@dcaratti @jenkins-tessares
mptcp: allow changing the "backup" bit by endpoint id
3d6e19c 
a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: #158
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
jenkins-tessares pushed a commit that referenced this issue Dec 2, 2021
@dcaratti @jenkins-tessares
mptcp: allow changing the "backup" bit by endpoint id
2b04a8f 
a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: #158
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Dec 2, 2021
@dcaratti @matttbe
mptcp: allow changing the "backup" bit by endpoint id
58ce72b 
a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: #158
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Dec 2, 2021
@dcaratti @matttbe
mptcp: allow changing the "backup" bit by endpoint id
b1b4c07 
a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: #158
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
matttbe pushed a commit that referenced this issue Dec 2, 2021
@dcaratti @matttbe
mptcp: allow changing the "backup" bit by endpoint id
c292b9a 
a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: #158
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this issue Dec 7, 2021
@dcaratti @kuba-moo
mptcp: allow changing the "backup" bit by endpoint id
602837e 
a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: multipath-tcp/mptcp_net-next#158
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
@matttbe
Copy link
Member Author

matttbe commented Dec 16, 2021

kernel and iproute2 patches have been sent upstream

@matttbe matttbe closed this as completed Dec 16, 2021
antonyantony pushed a commit to antonyantony/iproute2 that referenced this issue Dec 22, 2021
@dcaratti @dsahern
mptcp: add support for changing the backup flag
2611336 
Linux supports 'MPTCP_PM_CMD_SET_FLAGS' since v5.12, and this control has
recently been extended to allow setting flags for a given endpoint id.
Although there is no use for changing 'signal' or 'subflow' flags, it can
be helpful to set/clear the backup bit on existing endpoints: add the 'ip
mptcp endpoint change <...>' command for this purpose.

Link: multipath-tcp/mptcp_net-next#158
Acked-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: David Ahern <dsahern@kernel.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this issue Jan 30, 2022
@dcaratti
mptcp: allow changing the "backup" bit by endpoint id
0ad591f 
[ Upstream commit 602837e ]

a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: multipath-tcp/mptcp_net-next#158
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this issue Jan 30, 2022
@dcaratti
mptcp: allow changing the "backup" bit by endpoint id
5ca945e 
[ Upstream commit 602837e ]

a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: multipath-tcp/mptcp_net-next#158
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this issue Jan 30, 2022
@dcaratti @gregkh
mptcp: allow changing the "backup" bit by endpoint id
ebb3cd2 
[ Upstream commit 602837e ]

a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: multipath-tcp/mptcp_net-next#158
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this issue Jan 30, 2022
@dcaratti @gregkh
mptcp: allow changing the "backup" bit by endpoint id
901aecd 
[ Upstream commit 602837e ]

a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: multipath-tcp/mptcp_net-next#158
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this issue Jan 30, 2022
@dcaratti
mptcp: allow changing the "backup" bit by endpoint id
4e17c6b 
[ Upstream commit 602837e ]

a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: multipath-tcp/mptcp_net-next#158
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this issue Jan 30, 2022
@dcaratti
mptcp: allow changing the "backup" bit by endpoint id
ed686a9 
[ Upstream commit 602837e ]

a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: multipath-tcp/mptcp_net-next#158
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this issue Jan 31, 2022
@dcaratti
mptcp: allow changing the "backup" bit by endpoint id
a6d2f07 
[ Upstream commit 602837e ]

a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: multipath-tcp/mptcp_net-next#158
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this issue Jan 31, 2022
@dcaratti
mptcp: allow changing the "backup" bit by endpoint id
0fb5514 
[ Upstream commit 602837e ]

a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: multipath-tcp/mptcp_net-next#158
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
imaami pushed a commit to imaami/linux that referenced this issue Jan 31, 2022
@dcaratti @imaami
mptcp: allow changing the "backup" bit by endpoint id
249bbae 
[ Upstream commit 602837e ]

a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: multipath-tcp/mptcp_net-next#158
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this issue Jan 31, 2022
@dcaratti
mptcp: allow changing the "backup" bit by endpoint id
1eb1174 
[ Upstream commit 602837e ]

a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: multipath-tcp/mptcp_net-next#158
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this issue Jan 31, 2022
@dcaratti
mptcp: allow changing the "backup" bit by endpoint id
b579256 
[ Upstream commit 602837e ]

a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: multipath-tcp/mptcp_net-next#158
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this issue Jan 31, 2022
@dcaratti
mptcp: allow changing the "backup" bit by endpoint id
c37fa42 
[ Upstream commit 602837e ]

a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: multipath-tcp/mptcp_net-next#158
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this issue Jan 31, 2022
@dcaratti
mptcp: allow changing the "backup" bit by endpoint id
7962aed 
[ Upstream commit 602837e ]

a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: multipath-tcp/mptcp_net-next#158
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this issue Jan 31, 2022
@dcaratti
mptcp: allow changing the "backup" bit by endpoint id
9ab150b 
[ Upstream commit 602837e ]

a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: multipath-tcp/mptcp_net-next#158
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this issue Jan 31, 2022
@dcaratti @gregkh
mptcp: allow changing the "backup" bit by endpoint id
5b5985c 
[ Upstream commit 602837e ]

a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: multipath-tcp/mptcp_net-next#158
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this issue Jan 31, 2022
@dcaratti @gregkh
mptcp: allow changing the "backup" bit by endpoint id
3fa6fb9 
[ Upstream commit 602837e ]

a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: multipath-tcp/mptcp_net-next#158
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this issue Jan 31, 2022
@dcaratti
mptcp: allow changing the "backup" bit by endpoint id
eb64dbb 
[ Upstream commit 602837e ]

a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: multipath-tcp/mptcp_net-next#158
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this issue Jan 31, 2022
@dcaratti
mptcp: allow changing the "backup" bit by endpoint id
ff94479 
[ Upstream commit 602837e ]

a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: multipath-tcp/mptcp_net-next#158
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this issue Feb 1, 2022
@dcaratti
mptcp: allow changing the "backup" bit by endpoint id
b501184 
[ Upstream commit 602837e ]

a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: multipath-tcp/mptcp_net-next#158
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this issue Feb 1, 2022
@dcaratti
mptcp: allow changing the "backup" bit by endpoint id
c823256 
[ Upstream commit 602837e ]

a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: multipath-tcp/mptcp_net-next#158
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this issue Feb 1, 2022
@dcaratti
mptcp: allow changing the "backup" bit by endpoint id
5211ff0 
[ Upstream commit 602837e ]

a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: multipath-tcp/mptcp_net-next#158
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this issue Feb 1, 2022
@dcaratti
mptcp: allow changing the "backup" bit by endpoint id
5ca450a 
[ Upstream commit 602837e ]

a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: multipath-tcp/mptcp_net-next#158
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this issue Feb 1, 2022
@dcaratti
mptcp: allow changing the "backup" bit by endpoint id
3a5bcbf 
[ Upstream commit 602837e ]

a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: multipath-tcp/mptcp_net-next#158
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this issue Feb 1, 2022
@dcaratti
mptcp: allow changing the "backup" bit by endpoint id
341dca3 
[ Upstream commit 602837e ]

a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: multipath-tcp/mptcp_net-next#158
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-block that referenced this issue Feb 1, 2022
@dcaratti
mptcp: allow changing the "backup" bit by endpoint id
ede3bba 
[ Upstream commit 602837e ]

a non-zero 'id' is sufficient to identify MPTCP endpoints: allow changing
the value of 'backup' bit by simply specifying the endpoint id.

Link: multipath-tcp/mptcp_net-next#158
Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Signed-off-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcaratti dcaratti

Labels
enhancement iproute2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matttbe @dcaratti